fix(express,fastify): raw body for urlencoded requests #9926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #9901
What is the new behavior?
Registers raw body for
application/x-www-form-urlencoded
requests.Does this PR introduce a breaking change?
@fastify/formbody
did not allow any customization in the parsing process. Looking at the source code of that package, shows that it is incredibly small. In order to addreq.rawBody
, most of the code had to be duplicated. So I made the choice to remove registrationfastify/formbody
, and handle the content type ourselves in the exact same way. Only difference: thereq.rawBody
also gets assigned if the option was set.Keen eyes will also notice that I've added support for
bodyLimit
when registering these content parsers. The previous code (of mine) was missing this.Other information
Question:
We do not use
@fastify/formbody
anywere after these changes. Should I remove it frompackage.json
andpackage-lock.json
?