shall use leftJoin by default and support on clause

[Diluka]

crud/packages/crud-typeorm/src/typeorm-crud.service.ts

Lines 335 to 344 in 35acb44

	private getJoinType(relationType: string): string {
	switch (relationType) {
	case 'many-to-one':
	case 'one-to-one':
	return 'innerJoin';
	default:
	return 'leftJoin';
	}
	}

shall use leftJoin by default and use innerJoin by config
see sequelize options include.required behavior

If the relation can be set NULL, innerJoin will break the query.

refer: http://docs.sequelizejs.com/class/lib/model.js~Model.html#static-method-findAll

Name	Type	Attribute	Description
options.include[].required	boolean	optional	If true, converts to an inner join, which means that the parent model will only be loaded if it has any matching children. True if include.where is set, false otherwise.

[michaelyali]

Ok, let's make it be leftJoin by default, and add required: boolean as an option.
@Diluka would you like to make a PR? :) just asking. I can do it on my own

[Diluka]

export type QueryJoin = {
  field: string;
  select?: QueryFields;
  required?: boolean; // <-- add here?
  on?: string; // <-- maybe this together?
};

You do this PR is better. I need to take the time to familiarize myself with this new architecture.

When using left join and the relation can be set null, the same condition put in on or where can be different result.

p.s. I feel that it will become more and more complicated here.

[macchie]

UP! We had the same problem here :D

[michaelyali]

@Diluka @macchie this will have a high priority on the next release.

[macchie]

@Diluka @macchie this will have a high priority on the next release.

thanks! Great project!

[Diluka]

does this related to #31 ? @zMotivat0r

[michaelyali]

yep

[MeMeMax]

Is it correct that I can´t get e.g. only the data of the currently logged in user by now with the config options given or am I missing anything?

[sergak01]

UP! I have the same problem!

[Bnaya]

See possible workaround:
#31 (comment)

[cuni0716]

Not released yet @zmotivator?

[0x7061]

Has the on= config been ignored? I think this might be useful nevertheless.