Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for chafa #5355

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Add profile for chafa #5355

merged 1 commit into from
Sep 4, 2022

Conversation

alkim0
Copy link
Contributor

@alkim0 alkim0 commented Sep 1, 2022

chafa is a terminal image viewer.

As far as I know, there is no configuration file for chafa.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

No firecfg?

As far as I know, there is no configuration file for chafa.

How did you checked?

terminal image viewer.

What is a "terminal image viewer"? Does it display the image in the terminal? So we can deny X11 access?

etc/profile-a-l/chafa.profile Outdated Show resolved Hide resolved
etc/profile-a-l/chafa.profile Outdated Show resolved Hide resolved
etc/profile-a-l/chafa.profile Outdated Show resolved Hide resolved
etc/profile-a-l/chafa.profile Outdated Show resolved Hide resolved
etc/profile-a-l/chafa.profile Show resolved Hide resolved
etc/profile-a-l/chafa.profile Outdated Show resolved Hide resolved
etc/profile-a-l/chafa.profile Show resolved Hide resolved
@kmk3
Copy link
Collaborator

kmk3 commented Sep 2, 2022

Project links for reference:

@alkim0
Copy link
Contributor Author

alkim0 commented Sep 2, 2022

  • Added firecfg.
  • Denied x11 acess
  • Added no3d

Regarding configs, the program makes no mention about a config file in the man page/project home page.
I also did a firejail --trace, and found no accesses to home.

@kmk3
Copy link
Collaborator

kmk3 commented Sep 2, 2022

Could you squash/fixup the commits and force-push?

And leave only the following in the squashed commit message:

Add profile for chafa

Example using git rebase:

Also, feel free to amend the commits and force-push, as GitHub adds a timeline
event with a link to a comparison of the commits before/after the force-push.

@alkim0
Copy link
Contributor Author

alkim0 commented Sep 2, 2022

Incorporated all the latest changes (including things about x11) and readding notv, nou2f, and novideo.

Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: s/Added/Add/ in the commit message.

This matches the style used in the commit messages created by git itself.
Examples:

  • git merge --no-ff -> Merge ...
  • git revert -> Revert ...

See the following for details:

Other than that, LGTM.

etc/profile-a-l/chafa.profile Show resolved Hide resolved
@alkim0
Copy link
Contributor Author

alkim0 commented Sep 3, 2022

Incorporated additional suggestions

@kmk3 kmk3 changed the title Added profile for chafa Add profile for chafa Sep 3, 2022
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glitsj16 glitsj16 merged commit 529b38f into netblue30:master Sep 4, 2022
@alkim0 alkim0 deleted the chafa-profile branch September 5, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants