-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profile for chafa #5355
Add profile for chafa #5355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No firecfg?
As far as I know, there is no configuration file for chafa.
How did you checked?
terminal image viewer.
What is a "terminal image viewer"? Does it display the image in the terminal? So we can deny X11 access?
Project links for reference:
|
Regarding configs, the program makes no mention about a config file in the man page/project home page. |
Could you squash/fixup the commits and force-push? And leave only the following in the squashed commit message:
Example using Also, feel free to amend the commits and force-push, as GitHub adds a timeline |
Incorporated all the latest changes (including things about x11) and readding notv, nou2f, and novideo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: s/Added/Add/
in the commit message.
This matches the style used in the commit messages created by git itself.
Examples:
git merge --no-ff
->Merge ...
git revert
->Revert ...
See the following for details:
Other than that, LGTM.
Incorporated additional suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
chafa is a terminal image viewer.
As far as I know, there is no configuration file for chafa.