Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device_role -> role and add testing for Netbox 3.6 #1066

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Fix device_role -> role and add testing for Netbox 3.6 #1066

merged 4 commits into from
Sep 12, 2023

Conversation

FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Sep 6, 2023

Related Issue

device_role was renamed to role within the Netbox API for v3.6+
Filter for IP Addresses now require virtual_chassis_member_id to fetch VC member interfaces and device_id no longer returns the VC member interfaces.

Fixes #1061

New Behavior

Compatibility with Netbox APIs but no user changes need to occur.

Proposed Release Note Entry

Fix device_role being renamed to role in Netbox 3.6+ API
Change query params for searching interfaces when we need to find the VC member interfaces.

@rodvand
Copy link
Contributor

rodvand commented Sep 10, 2023

Could we merge the device_role fix and handle the VC issue in a different PR?

@FragmentedPacket
Copy link
Contributor Author

Could we merge the device_role fix and handle the VC issue in a different PR?

I fixed that one as well. There apparently is more breaking changes around IP addresses or maybe it's the code. I will leave this alone for now and keep those two fixes in while you review.

@rodvand rodvand merged commit 5f497b5 into netbox-community:devel Sep 12, 2023
@FragmentedPacket FragmentedPacket deleted the role-fix branch September 20, 2023 21:43
@sag2643
Copy link

sag2643 commented Sep 22, 2023

facing issues with the role msg": "{"role":["This field is required."]}"} , may i know if this has been fixed ?

@ma9icmarker
Copy link

do you know when this will be rolled into the next release?

@jonatangobbato
Copy link

do you know when this will be rolled into the next release?

@rodvand Is there any way to get around the problem for now until the next release?

@rodvand
Copy link
Contributor

rodvand commented Oct 11, 2023

do you know when this will be rolled into the next release?

@rodvand Is there any way to get around the problem for now until the next release?

Read https://docs.ansible.com/ansible/latest/collections_guide/collections_installing.html and just install it from the develop branch on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Breaking changes in 3.6.0, device_role -> role
5 participants