Added custom-field-choice-sets to nb_lookup.py #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since NetBox v3.6.0 the custom fields and the choices are splitted.
mariolenz
reviewed
Mar 18, 2024
Thank you @mariolenz Co-authored-by: Mario Lenz <[email protected]>
sc68cal
approved these changes
Apr 7, 2024
sc68cal
previously requested changes
Apr 7, 2024
sc68cal
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1185
New Behavior
Since NetBox v3.6.0 there is an breaking change where the custom-fields and choices are split.
Contrast to Current Behavior
Currently there is no way to access the custom field choices when using NetBox v3.6.0 or higher
Discussion: Benefits and Drawbacks
Why do you think this project and the community will benefit from your proposed change?
Starting from NetBox v3.6.0 it is not possible to use the lookup module to get the custom field choices.
What are the drawbacks of this change?
I do not know what happens when someone using it with an NetBox version lower than v3.6.0.
Is it backwards-compatible?
NetBox <v3.6.0; Use
custom-fieldsto get the choices.Netbox >v3.6.0; Use
custom-field-choice-setsChanges to the Documentation
...
Proposed Release Note Entry
Added
custom-field-choice-setsto the lookup plugin.Double Check
develbranch.