Added label to power port module #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc68cal
requested changes
Apr 7, 2024
sc68cal
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issues.
New Behavior
Added 'label' as a none required option to netbox_power_port module.
...
Contrast to Current Behavior
Possible to add a label to a power port in NetBox.
...
Discussion: Benefits and Drawbacks
We use NetBox in my organisation and I need to be able to create labels for powerports.
Since the option to add a label is optional it should not be a problem with backward compatibility.
...
Changes to the Documentation
Added a description of the label option in plugins/modules/netbox_power_port.py and generated a new version of
docs/plugins/netbox_power_port_module.rst.
...
Proposed Release Note Entry
...
Double Check
develbranch.