Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1256: Igore YAML indentation on changelog yaml file #1257

Merged
merged 1 commit into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ansible-lint-ignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# This file contains ignores rule violations for ansible-lint
changelogs/fragments/ yaml[comments]
changelogs/changelog.yaml yaml[indentation]
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Minor Changes
- Get ansible-lint passing again (sequence after `#1241 <https://github.com/netbox-community/ansible_modules/issues/1241>`_) `#1243 <https://github.com/netbox-community/ansible_modules/issues/1243>`_
- Update CI process to follow Ansible Collection Standards `#1247 <https://github.com/netbox-community/ansible_modules/issues/1247>`_
- Update CI to use master instead of main. `#1253 <https://github.com/netbox-community/ansible_modules/issues/1253>`_
- Update ansible-lint to ignore changelog file for yaml indentation. `#1256 <https://github.com/netbox-community/ansible_modules/issues/1256>`_
- Update top-level README with new minimum Ansible version (sequence after `#1241 <https://github.com/netbox-community/ansible_modules/issues/1241>`_ `#1244 <https://github.com/netbox-community/ansible_modules/issues/1244>`_
- Updated CI to only run changelog job if PR into devel branch is detected. `#1251 <https://github.com/netbox-community/ansible_modules/issues/1251>`_
- Updated CI to support NetBox 4.0 `#1230 <https://github.com/netbox-community/ansible_modules/pull/1230>`_
Expand Down
3 changes: 3 additions & 0 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
0.1.0:
changes:
breaking_changes:
- Changed ``group`` to ``tenant_group`` in ``netbox_tenant.py`` (https://github.com/netbox-community/ansible_modules/issues/9)

Check warning on line 6 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
- Changed ``role`` to ``prefix_role`` in ``netbox_prefix.py`` (https://github.com/netbox-community/ansible_modules/issues/9)
- Module failures when required fields arent provided (https://github.com/netbox-community/ansible_modules/issues/24)
- Renamed ``netbox_interface`` to ``netbox_device_interface`` (https://github.com/netbox-community/ansible_modules/issues/9)
minor_changes:
- Add ``primary_ip4/6`` to ``netbox_ip_address`` (https://github.com/netbox-community/ansible_modules/issues/10)

Check warning on line 11 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
modules:
- description: Creates or removes aggregates from NetBox

Check warning on line 13 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 6 but found 4
name: netbox_aggregate
namespace: ''
- description: Create, update or delete circuits within NetBox
Expand Down Expand Up @@ -94,28 +94,28 @@
0.1.1:
changes:
bugfixes:
- Fixed issue with netbox_vm_interface where it would fail if different virtual

Check warning on line 97 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
machine had the same interface name (https://github.com/netbox-community/ansible_modules/issues/40)
- Updated netbox_ip_address to find interfaces on virtual machines correctly
(https://github.com/netbox-community/ansible_modules/issues/40)
0.1.10:
changes:
bugfixes:
- Updated inventory plugin name from netbox.netbox.netbox to netbox.netbox.nb_inventory

Check warning on line 104 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
(https://github.com/netbox-community/ansible_modules/pull/129)
0.1.2:
changes:
bugfixes:
- Allow endpoint choices to be an integer of the choice rather than attempting

Check warning on line 109 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
to dynamically determine the choice ID (https://github.com/netbox-community/ansible_modules/issues/47)
0.1.3:
changes:
bugfixes:
- Add error handling for invalid key_file for lookup plugin (https://github.com/netbox-community/ansible_modules/issues/52)

Check warning on line 114 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
0.1.5:
changes:
bugfixes:
- Add argument specs for every module to validate data passed in. Fixes some

Check warning on line 118 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
idempotency issues. POSSIBLE BREAKING CHANGE (https://github.com/netbox-community/ansible_modules/issues/68)
- Allow name updates to manufacturers (https://github.com/netbox-community/ansible_modules/issues/76)
- Builds slug for netbox_device_type from model which is now required and slug
Expand All @@ -129,13 +129,13 @@
a /32 and pass to NetBox. Fixes idempotency cidr notation is not provided
(https://github.com/netbox-community/ansible_modules/issues/78)
modules:
- description: Creates or removes service from NetBox

Check warning on line 132 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 6 but found 4
name: netbox_service
namespace: ''
0.1.6:
changes:
bugfixes:
- Fixed vlan searching with vlan_group for netbox_prefix (https://github.com/netbox-community/ansible_modules/issues/85)

Check warning on line 138 in changelogs/changelog.yaml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

yaml[indentation]

Wrong indentation: expected 8 but found 6
- Removed static choices from netbox_utils and now pulls the choices for each
endpoint from the NetBox API at call time (https://github.com/netbox-community/ansible_modules/issues/67)
minor_changes:
Expand Down Expand Up @@ -726,6 +726,8 @@
`#1243 <https://github.com/netbox-community/ansible_modules/issues/1243>`_
- Update CI process to follow Ansible Collection Standards `#1247 <https://github.com/netbox-community/ansible_modules/issues/1247>`_
- Update CI to use master instead of main. `#1253 <https://github.com/netbox-community/ansible_modules/issues/1253>`_
- Update ansible-lint to ignore changelog file for yaml indentation. `#1256
<https://github.com/netbox-community/ansible_modules/issues/1256>`_
- Update top-level README with new minimum Ansible version (sequence after `#1241
<https://github.com/netbox-community/ansible_modules/issues/1241>`_ `#1244
<https://github.com/netbox-community/ansible_modules/issues/1244>`_
Expand All @@ -739,6 +741,7 @@
- housekeeping.yml
- issue_1249.yml
- issue_1253.yml
- issue_1256.yml
release_date: '2024-05-28'
3.2.0:
changes:
Expand Down
Loading