Inventory: Create groups based on rack groups, and rack roles #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouglasHeriot
force-pushed
the
rack-groups
branch
from
ecee38f to
ad190ee
Compare
|
To fix tests, I need to work out the best way to ignore "parent rack group" missing from the inventory in Netbox 2.6-2.7, as only 2.8 supports nested rack groups. |
DouglasHeriot
force-pushed
the
rack-groups
branch
3 times, most recently
from
e528f83 to
3f0cd83
Compare
|
Ok, I've fixed the tests now - this should be ready to review. |
|
@DouglasHeriot Do you mind fixing the conflict? I will also get this reviewed this weekend! |
|
Yep, I'll try and sort this this weekend. |
…-community#203) This is required to ignore comparing the rack_groups host var on NetBox 2.7. There is no good way to do this - the Ansible blog recently recommended writing a file inside the test target directory. https://www.ansible.com/blog/adding-integration-tests-to-ansible-content-collections
Requires ignoring some groups. Also remove old NetBox 2.6 test code.
Use bash array instead of unquoted variable.
DouglasHeriot
force-pushed
the
rack-groups
branch
from
dea72fc to
f9064b7
Compare
FragmentedPacket
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #203
Depends on pull request #202 - will rebase and mark as ready once that is merged.
Decided not to create a hierarchy of groups like I did for regions. Actually a little complicated to decide what groups to create when they're not all in use, or devices are filtered. Doesn't really impact usage or performance at all.