Copy interfaces before processing in extractor #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the variable first to fix it.
|
works perfectly, cant wait to see this merged 😻 |
|
I'd really like to see this merged. We have lots of machines with tags on their interfaces in netbox and each ansible run takes ages without a cache. |
|
Hello @philfry I asked @nahun to fetch upstream for the latest updates we added to the repo for 3.1.2. After the new CI completes, I am assuming it will complete successfully, can you please test for your issue? You can install his PR by: Assuming all goes well, we can get it released today or tomorrow. |
|
Hi @ryanmerolle, thanks! I'll test it asap tomorrow :) |
|
Hi, |
|
Hi, is there any ETA for a new release including this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535.
The interfaces extractor modifies the inventory as it processes the tags. Copy the interfaces list first instead.