Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #583: Move to Ansible-core for CI tests #591

Merged
merged 15 commits into from
Sep 17, 2021
Merged

Fixes #583: Move to Ansible-core for CI tests #591

merged 15 commits into from
Sep 17, 2021

Conversation

rodvand
Copy link
Contributor

@rodvand rodvand commented Sep 15, 2021

@ryanmerolle ryanmerolle mentioned this pull request Sep 15, 2021
Closed
@ryanmerolle
Copy link
Contributor

Closes #583

@ryanmerolle ryanmerolle linked an issue Sep 15, 2021 that may be closed by this pull request
CI does not run sanity tests with ansible-core 2.11 and ansible-core's devel branch #583
Closed
@ryanmerolle ryanmerolle mentioned this pull request Sep 16, 2021
Closed
ryanmerolle
ryanmerolle previously approved these changes Sep 16, 2021
View reviewed changes
sc68cal
sc68cal previously approved these changes Sep 16, 2021
View reviewed changes
felixfontein
felixfontein reviewed Sep 17, 2021
View reviewed changes
Copy link

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to remove the removals from this PR and wait with them for the next major release.

plugins/modules/netbox_device_interface.py Show resolved Hide resolved
plugins/modules/netbox_ip_address.py Show resolved Hide resolved
@felixfontein
Copy link

(Also you'd need a removed_features changelog fragment.)

@ryanmerolle
Copy link
Contributor

ryanmerolle commented Sep 17, 2021 •
edited
Loading

@rodvand, do you think you would be able to address @felixfontein comments. I will work with @FragmentedPacket and @jeremystretch to try to get a release cut and pushed to ansible galaxy before the next release of Ansible 4 this up coming Tuesday.

I have said it a few times, but I want to stress how helpful you have been to right this ship.

@rodvand
Copy link
Contributor Author

rodvand commented Sep 17, 2021

@rodvand, do you think you would be able to address @felixfontein comments. I will work with @FragmentedPacket and @jeremystretch to try to get a release cut and pushed to ansible galaxy before the next release of Ansible 4 this up coming Tuesday.

Working on it.

@rodvand
Re-add form_factor and family options.
24040a4 
Adjusted removed_in_verison.
@rodvand rodvand dismissed stale reviews from sc68cal and ryanmerolle via 24040a4 September 17, 2021 12:41
ryanmerolle
ryanmerolle approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@ryanmerolle ryanmerolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@felixfontein @gundalow @rodvand any final comments or items before I merge?

felixfontein
felixfontein approved these changes Sep 17, 2021
View reviewed changes
Copy link

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as far as I can judge :) )

@ryanmerolle ryanmerolle merged commit 20714cd into netbox-community:devel Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@ryanmerolle ryanmerolle ryanmerolle approved these changes

@sc68cal sc68cal sc68cal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI does not run sanity tests with ansible-core 2.11 and ansible-core's devel branch
4 participants
@rodvand @ryanmerolle @felixfontein @sc68cal