Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure netbox_service selects the right IP address #718

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

rodvand
Copy link
Contributor

@rodvand rodvand commented Feb 1, 2022

Fixes #470

New Behaviour

Allow the filtering of ipaddresses in netbox_service to use virtual_machine as query params. Example:

netbox.netbox.netbox_service:
  data:
    virtual_machine: VM One
    port: 443
    protocol: tcp
    name: https
    ipaddresses:
      - address: 127.0.0.1/8
        virtual_machine: VM One

Contrast to Current Behavior

Current functionality does not allow virtual_machine as a query param.

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@rodvand rodvand merged commit ec5af3b into netbox-community:devel Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: netbox_service finds multiple addresses instead of one
1 participant