Fix #805: Netbox ansible custom_fields are not idempotent

[cfiehe]

This fix ensures the idempotency of the Netbox modules when custom_fields are used.

Signed-off-by: Christoph Fiehe [email protected]

Related Issue

#805: Netbox ansible custom_fields are not idempotent

New Behavior

The fix removes all null values from the current custom fields and ensures that only values, which are actually set, are compared with the target state.

Contrast to Current Behavior

This new behavior ensures the idempotency of the Netbox modules when custom_fields are used.

Discussion: Benefits and Drawbacks

• Idempotency is an important topic in every configuration management tool, because it ensures that an already reached target state does not need any further configuration changes.
• From my point of view this fix is fully backward compatible and should have no unforeseen side-effects.
• One situation cannot be handled right now: When optional custom fields are used, which have a default value. There is no easy way to detect this, when the value is not contained in the target state provided via Ansible.

Changes to the Documentation

None.

Proposed Release Note Entry

None.

Double Check

• I have read the comments and followed the CONTRIBUTING.md.
• I have explained my PR according to the information in the comments or in a linked issue.
• My PR targets the devel branch.

[rodvand]

Thanks for the PR! Could you format your code using black? You can just run ./hacking/black.sh from the root folder.

[cfiehe]

Thanks for the PR! Could you format your code using black? You can just run ./hacking/black.sh from the root folder.

Yes, of course. I am sorry!

[sc68cal]

logic looks correct, just need to make black happy

[cfiehe]

Thank you very much 🙂.