Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nb_inventory group_by by site_group #952

Merged
merged 3 commits into from
Feb 25, 2023

Conversation

ryanmerolle
Copy link
Contributor

Related Issue

Closes #951

New Behavior

groups are created for each site_group when using the group_by feature with site_group

...

Contrast to Current Behavior

No groups created for site_groups

Discussion: Benefits and Drawbacks

Working group_by feature

Changes to the Documentation

N/A

Proposed Release Note Entry

...

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@ryanmerolle ryanmerolle changed the title Fix group_by by site group Fix nb_inventory group_by by site_group Feb 25, 2023
@ryanmerolle ryanmerolle requested a review from rodvand February 25, 2023 05:05
@ryanmerolle ryanmerolle self-assigned this Feb 25, 2023
@ryanmerolle ryanmerolle requested a review from sc68cal February 25, 2023 05:07
@rodvand rodvand merged commit 3477e82 into netbox-community:devel Feb 25, 2023
@ryanmerolle ryanmerolle deleted the group_by_site_group branch February 25, 2023 12:32
rodvand pushed a commit to rodvand/ansible_modules that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: group_by site_group is not working
2 participants