Minor updates on Forms and Filters #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's easier to use the filterset from netbox https://github.com/netbox-community/netbox/blob/v3.6.4/netbox/netbox/filtersets.py#L269 and thanks to inheritance the q method is already present. no need to implement it in the query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to filter BGP session with the site parameter as it's present on the model + serializer
Updating tags use on form as they are already present on class NetBoxModelForm (https://github.com/netbox-community/netbox/blob/develop/netbox/netbox/forms/base.py)
Added the possibility to filter prefix list by their ID