Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all id__in filters #4313

Closed
jeremystretch opened this issue Mar 4, 2020 · 1 comment
Closed

Remove all id__in filters #4313

jeremystretch opened this issue Mar 4, 2020 · 1 comment
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v2.8

Comments

@jeremystretch
Copy link
Member

jeremystretch commented Mar 4, 2020 •
edited
Loading

Proposed Changes

Many models within NetBox have a filter named id__in which enables filtering by comma-separated object IDs, e.g. ?id__in=1,2,3. This was introduced in #987 to accommodate form widget filtering logic that is no longer used in NetBox. This issue proposes to remove all instance of id__in filters as well as the NumericInFilter class (which has no other uses).

Justification

This method of filtering is no longer needed, and the same result can be achieved using the more standard approach of passing the id parameter multiple times: ?id=1&id=2&id=3
@jeremystretch jeremystretch added API change status: under review Further discussion is needed to determine this issue's scope and/or implementation type: deprecation Removal of existing functionality or behavior labels Mar 4, 2020
@jeremystretch jeremystretch added this to the v2.8 milestone Mar 4, 2020
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Mar 4, 2020
@jeremystretch jeremystretch self-assigned this Mar 6, 2020
jeremystretch added a commit that referenced this issue Mar 6, 2020
@jeremystretch
Closes #4313: Remove id__in filters
803287a
@jeremystretch jeremystretch mentioned this issue Apr 13, 2020
Merged
@sdktr sdktr mentioned this issue Apr 30, 2020
Closed
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue May 4, 2020
@DouglasHeriot
Update query_parameters for Netbox 2.8
793a635 
netbox-community/netbox#4313 removed id__in as you can acheive the same by listing id multiple times.
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue May 4, 2020
@DouglasHeriot
Update query_parameters for Netbox 2.8
03422dd 
netbox-community/netbox#4313 removed id__in as you can acheive the same by listing id multiple times.
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue May 5, 2020
@DouglasHeriot
Update query_parameters for Netbox 2.8
e90d043 
netbox-community/netbox#4313 removed id__in as you can acheive the same by listing id multiple times.
@loa
Copy link

loa commented May 6, 2020

Hey @jeremystretch !

I wonder, this seem to have removed the only way of batch fetching multiple ipam resources?

@loa loa mentioned this issue May 6, 2020
Closed
@jeremystretch jeremystretch mentioned this issue May 6, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v2.8
Development

No branches or pull requests
2 participants
@loa @jeremystretch