Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3663: add Filter Tests #3793

Merged
merged 3 commits into from
Dec 27, 2019

Conversation

struppinet
Copy link

@struppinet struppinet commented Dec 25, 2019

Amends: #3680

added the wished Filter Tests

@DanSheps
Copy link
Member

  1. Build is failing
  2. No open issue, what is this currently fixing?

@struppinet
Copy link
Author

lampwins wished for tests for this (#3680) so I added them.

netbox/extras/tests/test_api.py Outdated Show resolved Hide resolved
netbox/extras/tests/test_api.py Outdated Show resolved Hide resolved
netbox/extras/tests/test_api.py Show resolved Hide resolved
netbox/extras/tests/test_api.py Outdated Show resolved Hide resolved
@jeremystretch
Copy link
Member

I've tweaked this to indicate that it amends the work contributed under #3680. Please also see my feedback above.

@struppinet
Copy link
Author

Feedback has been applied. (tried save and failed on the automatic updated last_updated. didn't know about the update() method)

@jeremystretch
Copy link
Member

didn't know about the update() method)

You generally want to avoid using update() as it bypasses most validation, but it can be very helpful in niche cases like this.

@jeremystretch jeremystretch merged commit 0c5f535 into netbox-community:develop Dec 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants