Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Support zwo files better and other Minor Fixes. #150

Merged
merged 10 commits into from
Jul 14, 2024
Merged

Conversation

sHedC
Copy link
Collaborator

@sHedC sHedC commented Jul 8, 2024

Some additional fixes below, this requires a rebuild of the docker.

  • Fix the "How can I add custom .zwo files?" section in the README #89 Added the abiltiy to map a directory for custom zwo files to a local directory using an environment parameter, updated readme.
  • Minor Fix to Docker to make the entrypoint and other files rx by default (from just x)
  • Minor Fix for Podman Build to set ipc host temporarily, can cause failures on laptops
  • Fedora 40 with Nvidia - Performance #147 - Attempt to fix issue by moving the Enviornment Variables for NVIDIA
  • Update Readme to point to new Nvidia-container-toolkit not the deprecated one

@sHedC sHedC requested a review from netbrain July 8, 2024 17:05
@netbrain
Copy link
Owner

netbrain commented Jul 8, 2024

Looks good. 👍

@sHedC
Copy link
Collaborator Author

sHedC commented Jul 9, 2024

Added minor update to the ZWO section to talk about the subfolder and internal zwift id.

@sHedC sHedC requested a review from netbrain July 9, 2024 03:13
@sHedC
Copy link
Collaborator Author

sHedC commented Jul 10, 2024

@netbrain - FYI, Build is failing since last night due to some dependency in Wine that is blocked. Stable and Devel branches.

@netbrain
Copy link
Owner

Ok, you need anything from me?

@sHedC
Copy link
Collaborator Author

sHedC commented Jul 10, 2024

Ok, you need anything from me?

No its broken at the wine side, there is already an issue related. Just informing as you can't merge this request because build fails. I think something to do with related updates where the 64 and 32 bit library versons are conflicting.

I noticed as I was testng a new zwift builder workflow started failing last night.

Once fixed I will merge and build :)

@sHedC sHedC added the bug Something isn't working label Jul 11, 2024
@sHedC
Copy link
Collaborator Author

sHedC commented Jul 12, 2024

@netbrain - Trixie build still borked, due to issues between the 386 and 64 dependancies. It builds and runs with Bookworm but Nvidia using Experimental Wayland is stuffed in bookworm (no idea why).

Guess either wait for trixie to be fixed or note that Nvidia can't run in Wayland experimental mode. To be fair Nvidia under wayland is not good anyway as eventually the NVRAM fills and programs crash.

@sHedC sHedC removed the bug Something isn't working label Jul 14, 2024
@sHedC sHedC merged commit 4edcf1d into master Jul 14, 2024
@sHedC sHedC deleted the sHedC/issue89 branch July 14, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants