Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL Express Metrics #18992

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add SQL Express Metrics #18992

merged 1 commit into from
Nov 14, 2024

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Nov 12, 2024

Summary

Currently our Windows monitoring only have capability to monitor SQL Server. This PR is adding the recognition and possibility to also monitor Microsoft SQL Express.

Test Plan
Testing SQL Express
  1. Install SQL Express on your host. I tested this PR using version 2019
  2. Compile and install this branch locally. Netdata must recognize everything
Testing SQL Server
  1. Install SQL Server on your host. I tested this PR using version 2022.
  2. Verify netdata recognize it.
Additional Information
For users: How does this change affect me?

@thiagoftsm thiagoftsm marked this pull request as draft November 12, 2024 02:57
@github-actions github-actions bot added area/collectors Everything related to data collection collectors/windows labels Nov 12, 2024
@thiagoftsm thiagoftsm requested a review from stelfrag November 12, 2024 02:57
@thiagoftsm thiagoftsm marked this pull request as ready for review November 13, 2024 00:27
@ilyam8 ilyam8 merged commit aacc958 into netdata:master Nov 14, 2024
148 checks passed
@thiagoftsm thiagoftsm deleted the sqlexpress branch November 14, 2024 22:31
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Nov 20, 2024
@stelfrag stelfrag mentioned this pull request Nov 20, 2024
Ferroin pushed a commit that referenced this pull request Nov 21, 2024
(cherry picked from commit aacc958)
Ancairon pushed a commit to Ancairon/netdata that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection collectors/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants