Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] LGTM tag classification #4269

Merged
merged 2 commits into from
Sep 23, 2018
Merged

[WIP] LGTM tag classification #4269

merged 2 commits into from
Sep 23, 2018

Conversation

paulfantom
Copy link
Contributor

According to this doc: https://help.semmle.com/lgtm-enterprise/user/help/file-classification.html#built-in-tags we need to classify files to tell LGTM what they are for, this way it can exclude them from alerts.

As you can see, file classification is really a question of identifying the source or purpose of a file, and giving it a meaningful tag. Currently, the built-in tags are: docs, generated, library, template and test.

These tags can then be used to determine which files should have their results hidden. Currently, if a file has any classification (that is, at least one tag), its results are filtered out from results and statistics.

@paulfantom
Copy link
Contributor Author

Relates to #4259

@ktsaou ktsaou self-requested a review September 23, 2018 19:16
ktsaou
ktsaou previously approved these changes Sep 23, 2018
@paulfantom paulfantom changed the title LGTM tag classification [WIP] LGTM tag classification Sep 23, 2018
@paulfantom
Copy link
Contributor Author

Turns out we need to merge this first for LGTM to kick in :(

@paulfantom
Copy link
Contributor Author

I am testing various configs in separate repo: https://github.com/paulfantom/netdata-lgtm

@ktsaou ktsaou merged commit bbea403 into netdata:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants