This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Cache Leiningen and Boot dependencies #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on this! We will take a chance to review this soon, but the holidays are just a bit slow (everyone is off!) |
|
Please let me know if you want any changes to this, to get it merged :) |
brycekahle
suggested changes
Jan 12, 2018
run-build-functions.sh
Outdated
| @@ -306,11 +308,14 @@ install_dependencies() { | |||
| # Leiningen | |||
| if [ -f project.clj ] | |||
| then | |||
| mkdir -p $NETLIFY_CACHE_DIR/m2 | |||
| ln -nfs $NETLIFY_CACHE_DIR/m2 ~/.m2 | |||
| if [ -d $NETLIFY_CACHE_DIR/.m2 ]; | |||
There was a problem hiding this comment.
Please remove the semicolon. It looks like we aren't 100% consistent, but the vast majority do not have semicolons.
run-build-functions.sh
Outdated
| @@ -327,8 +332,16 @@ install_dependencies() { | |||
| # Boot | |||
| if [ -f build.boot ] | |||
| then | |||
| mkdir -p $NETLIFY_CACHE_DIR/m2 | |||
| ln -nfs $NETLIFY_CACHE_DIR/m2 ~/.m2 | |||
| if [ -d $NETLIFY_CACHE_DIR/.m2 ]; | |||
run-build-functions.sh
Outdated
| rm -rf $NETLIFY_BUILD_BASE/.m2 | ||
| mv $NETLIFY_CACHE_DIR/.m2 $NETLIFY_BUILD_BASE/.m2 | ||
| fi | ||
| if [ -d $NETLIFY_CACHE_DIR/.boot ]; |
brycekahle
approved these changes
Jan 12, 2018
|
@adamrenklint This won't go out until Monday most likely. I'll be sure to ping you when it does. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces caching of Leiningen and Boot dependencies, i.e.
~/.m2and~/.boot, making Netlify a great tool to build static sites and SPAs with Clojure and ClojureScript.