Move NF-build node to later image and lock node 10 version. #418
Conversation
mheffner
added
the
type: feature
I don't see where we're installing the node version for Netlify Build now. According to netlify/build#1239 (comment) it looks like we want 12.16.*. Am I missing it? |
|
I think it is installed in the buildbot |
|
Oh, nice! |
|
Yeah, we're going to pull the NF node into a separate build image layer that we'll install the plugins in. Since we'll need to update that more rapidly, figured separating from the build-image would be better. |
| cd / | ||
|
|
||
| ENV ELM_VERSION=0.19.0-bugfix6 | ||
| ENV YARN_VERSION=1.13.0 | ||
|
|
||
| ENV NETLIFY_BUILD_NODE_VERSION="12.16.1" | ||
| ENV NETLIFY_NODE_VERSION="10.20.1" |
There was a problem hiding this comment.
Why is this NETLIFY_NODE_VERSION and not NODE_VERSION?
There was a problem hiding this comment.
No particular reason, more that it represents the version Netlify has chosen for the image. 🤷
There was a problem hiding this comment.
Note that, as opposed to NETLIFY_NODE_VERSION, NODE_VERSION is the name of the environment variable used by users to specify a custom Node.js version. I am not sure whether that would be a good thing or not in this instance.
There was a problem hiding this comment.
Yeah, that shouldn't interfere. These ENV's are only present during the docker build phase.
mheffner
force-pushed
the
remove-netlify-build-node
branch
from
299ff6e to
621606e
Compare
|
This branch name is somewhat a misnomer now that #413 has been merged. This just locks the Node version and upgrades NVM version slightly. |
Preparing for future netlify-build image changes.