fix: ignore plugin process kill errors

netlify · Dec 10, 2024 · f0ff5e6 · f0ff5e6
1 parent ef92c48
commit f0ff5e6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/packages/build/src/plugins/spawn.ts b/packages/build/src/plugins/spawn.ts
@@ -217,5 +217,11 @@ const stopPlugin = async function ({
     })
     childProcess.disconnect()
   }
-  childProcess.kill()
+  try {
+    childProcess.kill()
+  } catch {
+    // In Node 22, there's a bug where attempting to kill a child process
+    // results in an EPERM error. Ignore the error in that case.
+    // See: https://github.com/nodejs/node/issues/51766
+  }
 }
diff --git a/packages/edge-bundler/node/server/util.ts b/packages/edge-bundler/node/server/util.ts
@@ -43,9 +43,15 @@ const killProcess = (ps: ExecaChildProcess<string>) => {
     ps.on('close', resolve)
     ps.on('error', reject)
 
-    ps.kill('SIGTERM', {
-      forceKillAfterTimeout: SERVER_KILL_TIMEOUT,
-    })
+    try {
+      ps.kill('SIGTERM', {
+        forceKillAfterTimeout: SERVER_KILL_TIMEOUT,
+      })
+    } catch {
+      // In Node 22, there's a bug where attempting to kill a child process
+      // results in an EPERM error. Ignore the error in that case.
+      // See: https://github.com/nodejs/node/issues/51766
+    }
   })
 }