Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimal Node.js version to Node 12 #3741

Closed
ehmicky opened this issue Oct 15, 2021 · 2 comments
Closed

Upgrade minimal Node.js version to Node 12 #3741

ehmicky opened this issue Oct 15, 2021 · 2 comments
Assignees
Labels
type: chore work needed to keep the product and development running smoothly

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Oct 15, 2021

See background at https://github.com/netlify/team-dev/issues/34

We should upgrade the minimal Node.js version to Node >=12.20.0 and make a major release.
This applies to all packages of this monorepo, including @netlify/build and @netlify/config.

This should only be done after Node 10 support in Netlify CLI has been dropped first (netlify/cli#3512).

This would not break sites because:

  • The buildbot is already running @netlify/build with Node 12.
  • Users would still be allowed to run Node 10 with their build commands.
  • Plugins installed in the UI or in netlify.toml (not package.json) are already running with Node 12
  • Local plugins and plugins in package.json are also using Node 12, except for sites with a user-defined Node.js version. For those, the user-defined Node.js version is used instead, except when it is older than the minimal Node.js version supported by @netlify/build. This means any site with such plugins and a user-defined Node.js version of 10 would run those plugins with Node 12 instead.
@ehmicky
Copy link
Contributor Author

ehmicky commented Nov 22, 2021

Started at #3873

@ehmicky
Copy link
Contributor Author

ehmicky commented Nov 24, 2021

Cleanup PRs at #3880, #3881, #3882, #3883

@ehmicky ehmicky closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

No branches or pull requests

1 participant