Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve plugin process IPC #3880

Merged
merged 2 commits into from
Nov 25, 2021
Merged

fix: improve plugin process IPC #3880

merged 2 commits into from
Nov 25, 2021

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Nov 24, 2021

Part of #3741

Now that Node.js 10 support has been dropped, we can upgrade the IPC format used by Build plugins from JSON to the structured clone algorithm (v8.serialize()).


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Nov 24, 2021
@ehmicky ehmicky self-assigned this Nov 24, 2021
@kodiakhq kodiakhq bot merged commit ded368d into main Nov 25, 2021
@kodiakhq kodiakhq bot deleted the chore/ipc-advanced branch November 25, 2021 17:18
@ehmicky ehmicky mentioned this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants