Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document deno_import_map in function types #5305

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Sep 25, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

See opennextjs/opennextjs-netlify#2302 (comment) - we're missing the deno_import_map field in our types for functions.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@Skn0tt Skn0tt requested review from a team as code owners September 25, 2023 11:32
@Skn0tt Skn0tt self-assigned this Sep 25, 2023
@Skn0tt Skn0tt enabled auto-merge (squash) September 25, 2023 11:33
@Skn0tt Skn0tt merged commit 21cafcf into main Sep 25, 2023
@Skn0tt Skn0tt deleted the types-deno-import-map branch September 25, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants