Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert buffers into blobs before calling blobStore.set #5921

Closed
wants to merge 1 commit into from

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Dec 4, 2024

Summary

Fixes typescript issue in main branch that's blocking test runs


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork marked this pull request as ready for review December 4, 2024 23:18
@mrstork mrstork requested a review from a team as a code owner December 4, 2024 23:18
Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be worth a quick manual test before releasing it to buildbot, just to be extra safe. If you link this into netlify/cli locally and deploy a Next.js site, that should exercise this code path. Ping me if you need help with that 🙂.

@mrstork mrstork closed this Dec 6, 2024
@mrstork mrstork deleted the fix-typescript-issue branch December 6, 2024 15:48
@mrstork
Copy link
Contributor Author

mrstork commented Dec 6, 2024

Replaced by #5927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants