-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove node 10 support #3648
Conversation
π Benchmark resultsComparing with a875fb7 Package size: 364 MBβ¬οΈ 0.00% decrease vs. a875fb7
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking π₯ @lukasholzer, answered your question about Edge Handlers and added a comment.
src/functions-templates/javascript/google-analytics/package.json
Outdated
Show resolved
Hide resolved
This is looking great to me too! π |
Yea currently figuring out why the tests are failing β therefore I set the PR in the draft state. This should indicate that it is not ready for review β I try to create always fast PR's so that folks that are interested can already see in which direction it turns, fast feedback. But it is strange that it is failing as my changes should not influence that |
opened up a issuei in the edge handler to drop support netlify-plugin-edge-handlers#660
The |
I updated the branch protections settings, so this should be fixed now |
You should be able to do it too I think as you're a part of https://github.com/orgs/netlify/teams/netlify-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
π Thanks for submitting a pull request! π
Summary
Fixes #3512
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)