-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev): enable the usage of the command property without port #3662
feat(dev): enable the usage of the command property without port #3662
Conversation
π Benchmark resultsComparing with 51bde9a Package size: 365 MBβ¬οΈ 0.00% decrease vs. 51bde9a
Legend
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far, and works for me locally with Remix. The behaviour is a significant change though, so you should ensure that you test various scenarios to avoid breaking existing sites.
7b9492d
to
a5d85ac
Compare
This will probably need a docs update, explaing that if targetPort is provided then it will wait for that port to open, and proxy to it, and if it's not provided then the static server will be used. |
I think it should be updated here as well: https://docs.netlify.com/configure-builds/file-based-configuration/#netlify-dev Hey as the docs in the repo are "autogenerated" |
What's needed to land this? It would be great to get this out, now that Remix has been released |
@ascorbic I'm opening up a PR on the docs site as well to change it but IMHO we can release it first ;) From my point, it should be good to go but I'm the PR issuer so maybe @ehmicky can provide here more information. The doc's site does not say that this is not working what we implemented so we only need to explain this use case a little bit more there: https://docs.netlify.com/configure-builds/file-based-configuration/#netlify-dev |
Great! Could you complete the PR description now it's ready for review? |
π Thanks for submitting a pull request! π
Summary
Fixes #3654
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)