-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: drop support for Node 13
, 14.0.0-14.13.1
and 15
#3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
work needed to keep the product and development running smoothly
label
Nov 24, 2021
📊 Benchmark resultsComparing with 08323af Package size: 365 MB⬇️ 0.00% decrease vs. 08323af
Legend
|
ehmicky
force-pushed
the
chore/node-13-15
branch
from
November 24, 2021 14:37
755cd61
to
6ed7b8a
Compare
ehmicky
changed the title
chore!: drop support for Node
chore!: drop support for Node Nov 24, 2021
13
, 14.0.0-14.13.0
and 15
13
, 14.0.0-14.13.1
and 15
lukasholzer
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for taking care of it ❤️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: chore
work needed to keep the product and development running smoothly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion at netlify/netlify-headers-parser#80 (comment)
Discussing with @lukasholzer and @JGAntunes we decided to drop support for Node 13, 15 and 14 below 14.14.0.
This will require a major release and editing our previous announcement.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.