Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct protocol when displaying function URL #4605

Merged
merged 1 commit into from
May 13, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/functions/netlify-function.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ class NetlifyFunction {
// Not sure why `settings.port` was used here nor does a valid reference exist.
// However, it remains here to serve whatever purpose for which it was added.
const port = this.settings.port || this.settings.functionsPort
const protocol = this.settings.https ? 'https' : 'http'
const url = new URL(`/.netlify/functions/${this.name}`, `${protocol}://localhost:${port}`)

const url = new URL(`/.netlify/functions/${this.name}`, `http://localhost:${port}`)
return url.href
}
}
Expand Down