fix: check if endpoint exists for dynamic pages when checking for red… #6994
+937
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const isEndpointExists = async function (endpoint: string, origin: string) { | ||
| const url = new URL(endpoint, origin) | ||
| try { | ||
| const res = await fetch(url, { method: 'HEAD' }) |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 9 hours ago
To fix the problem, we need to ensure that the user input is validated and sanitized before being used to construct the URL for the fetch request. One effective way to do this is to use an allow-list of acceptable paths or endpoints. This way, we can ensure that only known and safe endpoints are used in the fetch request.
- Create an allow-list of acceptable paths or endpoints.
- Validate the
req.urlagainst this allow-list before using it to construct the URL for thefetchrequest. - If the
req.urlis not in the allow-list, handle the request appropriately (e.g., return a 400 Bad Request response).
Suggested changeset
1
src/utils/proxy.ts
| @@ -152,2 +152,6 @@ | ||
| const isEndpointExists = async function (endpoint: string, origin: string) { | ||
| const allowList = ['/allowed-path1', '/allowed-path2', '/allowed-path3'] | ||
| if (!allowList.includes(endpoint)) { | ||
| throw new Error('Endpoint not allowed') | ||
| } | ||
| const url = new URL(endpoint, origin) |
Copilot is powered by AI and may make mistakes. Always verify output.
There was a problem hiding this comment.
Not really sure this is useful, should we dismiss it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…irect
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes WRFL-2122
Basically we are checking only for static files when trying to determinate if we should do the
non forcedredirect.In dynamic SSG, when they either run in
dev modeor having dynamic endpoints (not a static files), we are not detecting it and doing the redirect, which is wrong.I've added a simple checker via
fetch url, { method: HEAD }- which checks if the endpoint exists.Example
Assume next
netlify.toml:Run
netlify dev.Make change to some code file.
Open
http://localhost:8888. See that change is not applied. See in consoleProxying to https://www.netlify.app/.Thats wrong, it should actually detect that there is an index route in current site and not proxy.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)