Skip to content

Commit

Permalink
fix: remove disallow-code-generation-from-strings flag (#177)
Browse files Browse the repository at this point in the history
version 1.27.1 does not work with this flag and as it turned out it was
introduced to disallow eval() in dev, because it wasn't allowed in prod.
No eval() is available in prod
  • Loading branch information
danez authored Nov 4, 2022
1 parent f7ff2fc commit d344992
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions node/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,7 @@ const serve = async ({
// Creating an ImportMap instance with any import maps supplied by the user,
// if any.
const importMap = new ImportMap(importMaps)
const flags = [
'--allow-all',
'--unstable',
`--import-map=${importMap.toDataURL()}`,
'--v8-flags=--disallow-code-generation-from-strings',
'--no-config',
]
const flags = ['--allow-all', '--unstable', `--import-map=${importMap.toDataURL()}`, '--no-config']

if (certificatePath) {
flags.push(`--cert=${certificatePath}`)
Expand Down

0 comments on commit d344992

Please sign in to comment.