fix: detect extraneous files

node/npm_dependencies.ts

@@ -124,6 +124,23 @@ const getNPMSpecifiers = async (
   const npmSpecifiersWithExtraneousFiles = new Set<string>()
 
   for (const [packageJsonPath, reason] of reasons.entries()) {
+    const parents = [...reason.parents]
+    const isExtraneousFile = reason.type.every((type) => type === 'asset')
+
+    // An extraneous file is a dependency that was traced by NFT and marked
+    // as not being statically imported. We can't process dynamic importing
+    // at runtime, so we gather the list of modules that may use these files
+    // so that we can warn users about this caveat.
+    if (isExtraneousFile) {
+      parents.forEach((path) => {
+        const specifier = getPackageName(path)
+
+        if (specifier) {
+          npmSpecifiersWithExtraneousFiles.add(specifier)
+        }
+      })
+    }
+
     // every dependency will have its `package.json` in `reasons` exactly once.
     // by only looking at this file, we save us from doing duplicate work.
     const isPackageJson = packageJsonPath.endsWith('package.json')
@@ -132,8 +149,6 @@ const getNPMSpecifiers = async (
     const packageName = getPackageName(packageJsonPath)
     if (packageName === undefined) continue
 
-    const parents = [...reason.parents]
-
     const isDirectDependency = parents.some((parentPath) => {
       if (!parentPath.startsWith(`node_modules${path.sep}`)) return true
       // typically, edge functions have no direct dependency on the `package.json` of a module.
@@ -152,22 +167,6 @@ const getNPMSpecifiers = async (
         types: referenceTypes ? await safelyDetectTypes(path.join(basePath, packageJsonPath)) : undefined,
       })
     }
-
-    const isExtraneousFile = reason.type.every((type) => type === 'asset')
-
-    // An extraneous file is a dependency that was traced by NFT and marked
-    // as not being statically imported. We can't process dynamic importing
-    // at runtime, so we gather the list of modules that may use these files
-    // so that we can warn users about this caveat.
-    if (isExtraneousFile) {
-      parents.forEach((path) => {
-        const specifier = getPackageName(path)
-
-        if (specifier) {
-          npmSpecifiersWithExtraneousFiles.add(specifier)
-        }
-      })
-    }
   }
 
   return {

node/server/server.test.ts

@@ -47,7 +47,7 @@ test('Starts a server and serves requests for edge functions', async () => {
     getFunctionsConfig: true,
   }
 
-  const { features, functionsConfig, graph, success } = await server(
+  const { features, functionsConfig, graph, success, npmSpecifiersWithExtraneousFiles } = await server(
     functions,
     {
       very_secret_secret: 'i love netlify',
@@ -57,6 +57,7 @@ test('Starts a server and serves requests for edge functions', async () => {
   expect(features).toEqual({ npmModules: true })
   expect(success).toBe(true)
   expect(functionsConfig).toEqual([{ path: '/my-function' }, {}, { path: '/global-netlify' }])
+  expect(npmSpecifiersWithExtraneousFiles).toEqual(['dictionary'])
 
   for (const key in functions) {
     const graphEntry = graph?.modules.some(
@@ -104,7 +105,7 @@ test('Starts a server and serves requests for edge functions', async () => {
     `/// <reference types="${join('..', '..', '..', 'node_modules', 'id', 'types.d.ts')}" />`,
   )
 
-  const identidadeBarrelFile = await readFile(join(servePath, 'barrel-1.js'), 'utf-8')
+  const identidadeBarrelFile = await readFile(join(servePath, 'barrel-2.js'), 'utf-8')
   expect(identidadeBarrelFile).toContain(
     `/// <reference types="${join(
       '..',

test/fixtures/serve_test/netlify/edge-functions/echo_env.ts

@@ -4,6 +4,14 @@ import { yell } from 'helper'
 import id from 'id'
 import identidade from '@pt-committee/identidade'
 
+import { getWords } from 'dictionary'
+
+// this will throw since FS access is not available in Edge Functions.
+// but we need this line so that `dictionary` is scanned for extraneous dependencies
+try {
+  getWords()
+} catch {}
+
 export default () => {
   return new Response(yell(identidade(id(Deno.env.get('very_secret_secret'))) ?? ''))
 }