fix: implement retries for Deno CLI download and additional logging #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiewmacharia
changed the title
eduardoboucas
previously approved these changes
Aug 16, 2022
…-bundler into fix/retry-deno-cli-download
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…etlify/edge-bundler#100) * fix: implement retries for Deno CLI download and additional logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
This PR adds additional system logging for Edge Functions bundling and adds retries to Deno CLI download.
If retries are triggered for download, logger.system will have a record of retry attempts similar to the below screenshot:
Relates to https://github.com/netlify/pillar-support/issues/22
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Example: I'm always frustrated when [...]
List other issues or pull requests related to this problem
Example: This fixes #5012
Describe the solution you've chosen
Example: I've fixed this by [...]
Describe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
