-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate edge function signature at build time #200
Merged
jackiewmacharia
merged 15 commits into
main
from
feat/validate-edge-function-at-build-time
Nov 18, 2022
Merged
feat: validate edge function signature at build time #200
jackiewmacharia
merged 15 commits into
main
from
feat/validate-edge-function-at-build-time
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of thoughts/pointers on this:
|
jackiewmacharia
commented
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments, but otherwise looking great!
eduardoboucas
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…ndler#200) * feat: validate edge function signature at build time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Example: I'm always frustrated when [...]
List other issues or pull requests related to this problem
This fixes https://github.com/netlify/pod-compute/issues/249
Describe the solution you've chosen
Example: I've fixed this by [...]
Describe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)