fix: tag edge function signature errors as user errors #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/config.ts
Outdated
| `Default export in '${func.path}' must be a function. More on the Edge Functions API at https://ntl.fyi/edge-api.`, | ||
| ), | ||
| // empty string because it's not associated with a bundling format | ||
| { format: '' }, |
There was a problem hiding this comment.
Rather than specifying this, could we make the options parameter in wrapBundleError optional?
I would go as far as making the options parameter in the BundleError constructor itself optional, and I'd call it directly from here:
throw new BundleError(`Default export in '${func.path}' must be a function. More on the Edge Functions API at https://ntl.fyi/edge-api.`)I think the purpose of wrapBundleError is to wrap something that may or may not be an error. In this case we know for a fact that we're dealing with an error because we're the ones creating it.
jackiewmacharia
deleted the
fix/tag-ef-signature-errors-as-user-errors
branch
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…bundler#209) * fix: tag edge function signature errors as user errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Example: I'm always frustrated when [...]
List other issues or pull requests related to this problem
Example: This fixes #5012
Describe the solution you've chosen
Example: I've fixed this by [...]
Describe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)