feat: add support for denoDir parameter
#80
Conversation
eduardoboucas
added
the
type: feature
| } | ||
|
|
||
| if (cacheDirectory !== undefined && featureFlags.edge_functions_cache_deno_dir) { | ||
| options.denoDir = join(cacheDirectory, 'deno_dir') |
There was a problem hiding this comment.
cacheDirectory is set by build to a cachable directory?
There was a problem hiding this comment.
Could that potentially mean that dependencies which are cached to never get updated? or is the full version always included in the URL?
Kind of unrelated:
Same actually for the cli, if we cache it in buildbot it will never get updated? Also why not install the deno CLI in the build-image directly, to save time and traffic on caching and downloading/installing deno? Sorry for these questions just trying to understand the history.
There was a problem hiding this comment.
Could that potentially mean that dependencies which are cached to never get updated? or is the full version always included in the URL?
Yes, the version should be included in the URL. Having a permanent directory that the Deno CLI can use to cache different things is its normal operation mode. This means not only caching remote dependencies, but also the result of compiling TypeScript to JavaScript.
Currently, we're forcing it to "start from scratch" on every build, which comes with a performance penalty.
Same actually for the cli, if we cache it in buildbot it will never get updated?
We store the version of the CLI that is cached locally and we compare it against the version that Edge Bundler requires. If there's not a match, we download a fresh version. You can see that logic here.
Also why not install the deno CLI in the build-image directly, to save time and traffic on caching and downloading/installing deno?
See https://github.com/netlify/pillar-workflow/issues/504.
Sorry for these questions just trying to understand the history.
No problem at all. These are great questions.
* feat: add support for `denoDir` parameter * chore: improve test
Which problem is this pull request solving?
Adds a
denoDirparameter to thebundlefunction. When set, its value is used to set theDENO_DIRenvironment variable.List other issues or pull requests related to this problem
https://github.com/netlify/pod-compute/issues/161