Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

feat!: add Remix, make dev port optional #658

Merged
merged 4 commits into from
Jan 10, 2022
Merged

feat!: add Remix, make dev port optional #658

merged 4 commits into from
Jan 10, 2022

Conversation

jlengstorf
Copy link
Contributor

This starts the process of adding Remix to framework detection. There are a few open questions that I think I need @netlify/integrations to help with:

  1. Right now we have to run both remix watch and netlify dev together and I'm not sure how to approach that or if it's possible to simplify
  2. Remix uses port 8888, which I think is going to cause problems and I'm not sure if there's config available to fix it

I'm happy to close this PR if you've already got one rolling. If not, I figured I'd try to get the ball rolling as much as possible so we can get seamless Remix support in place.

Thanks!

@jlengstorf jlengstorf added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 7, 2022
src/frameworks/remix.json Outdated Show resolved Hide resolved
@erezrokah erezrokah changed the title wip: add Remix details feat!: add Remix, make dev port optional Jan 10, 2022
@erezrokah erezrokah marked this pull request as ready for review January 10, 2022 16:04
@erezrokah
Copy link
Contributor

@ascorbic, assuming we do netlify/cli#3655 (only run the dev command and use a static server), this should work for Remix correct? If so can you approve it?

Putting aside the CLI server port, which we can handle in another issue.

@ascorbic
Copy link
Contributor

Yes, but critically important that this isn't released without that, as it will break all Remix builds otherwise.

src/frameworks/remix.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't release until the CLI can handle it!

@erezrokah
Copy link
Contributor

erezrokah commented Jan 10, 2022

But don't release until the CLI can handle it!

Going to release under a major version (as it's a breaking change), then handle the CLI renovate PR manually.

@erezrokah erezrokah merged commit 0c4e5bd into main Jan 10, 2022
@erezrokah erezrokah deleted the jl/add-remix branch January 10, 2022 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants