This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
feat!: add Remix, make dev port optional #658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Jan 7, 2022
@ascorbic, assuming we do netlify/cli#3655 (only run the
|
Yes, but critically important that this isn't released without that, as it will break all Remix builds otherwise. |
ascorbic
reviewed
Jan 10, 2022
ascorbic
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But don't release until the CLI can handle it!
Going to release under a major version (as it's a breaking change), then handle the CLI renovate PR manually. |
This was referenced Jan 12, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the process of adding Remix to framework detection. There are a few open questions that I think I need @netlify/integrations to help with:
remix watch
andnetlify dev
together and I'm not sure how to approach that or if it's possible to simplifyI'm happy to close this PR if you've already got one rolling. If not, I figured I'd try to get the ball rolling as much as possible so we can get seamless Remix support in place.
Thanks!