Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

feat!: add Remix, make dev port optional #658

Merged
merged 4 commits into from
Jan 10, 2022
Merged

feat!: add Remix, make dev port optional #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85b38ec
wip: add Remix details
jlengstorf Jan 7, 2022
1b42735
feat: allow empty port
erezrokah Jan 10, 2022
3fdf309
Merge branch 'main' into jl/add-remix
erezrokah Jan 10, 2022
9ae44ec
fix: remove staticAssetsDirectory
erezrokah Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/frameworks/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ module.exports.FRAMEWORK_NAMES = [
'phenomic',
'react-static',
'redwoodjs',
'remix',
'stencil',
'vuepress',
'assemble',
Expand Down
19 changes: 19 additions & 0 deletions src/frameworks/remix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"id": "remix",
"name": "Remix",
"category": "static_site_generator",
"detect": {
"npmDependencies": ["remix", "@remix-run/netlify"],
"excludedNpmDependencies": [],
"configFiles": ["remix.config.mjs"]
},
"dev": {
"command": "remix watch"
},
"build": {
"command": "remix build",
"directory": "public"
},
"env": {},
"plugins": []
}
2 changes: 1 addition & 1 deletion test/frameworks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const FRAMEWORK_JSON_SCHEMA = {
oneOf: [
{
type: 'object',
required: ['command', 'port', 'pollingStrategies'],
required: ['command'],
additionalProperties: false,
properties: {
command: COMMAND_SCHEMA,
Expand Down