This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix: add missing frameworks to main.js #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
reviewed
Dec 10, 2020
test/frameworks.js
Outdated
| @@ -74,3 +81,13 @@ each(FRAMEWORKS, (info, framework) => { | |||
| t.is(validate(framework, FRAMEWORK_JSON_SCHEMA), true) | |||
| }) | |||
| }) | |||
|
|
|||
| test('each json file should be required in main.js FRAMEWORKS', async (t) => { | |||
| const dir = path.join(__dirname, '..', 'src', 'frameworks') | |||
There was a problem hiding this comment.
[sand] In most cases, using forward slashes work on Windows, because almost all the Node.js API methods (like fs.readdir()) handle. Usually, path.join() only matters when the file path is output to a file or a terminal, or is a binary executed in the terminal. See some write-up on this
There was a problem hiding this comment.
Thanks, fixed in a6084a8
ehmicky
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing frameworks to
main.jsand adds a test to verify there are no missing ones