This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
feat: add framework logos where available #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove react app since we are no longer using it
Shouldn't need it anymore with the react example site removed
also remove packages that were being used in the original test site, but are now not being used
there's an area within the netlify UI that uses this package and the earlier changes broke it
Use SVG from press kit rather than PNG from the Github project
github-actions
bot
added
the
type: feature
MarcL
reviewed
Aug 2, 2022
nickytonline
previously approved these changes
Aug 9, 2022
| @@ -16,6 +16,11 @@ | |||
| "command": "react-static build", | |||
| "directory": "dist" | |||
| }, | |||
| "logo": { | |||
| "default": "/logos/react-static/default.png", | |||
There was a problem hiding this comment.
Are there SVG versions of this logo? nvm, I see you mentioned this above.
React static logo is only available in PNG. I can ask about an SVG but the project is in maintenance mode so not sure about whether it's worth it to ask
Never hurts to ask. 😄
Can you create a separate issue for the above?
Definitely reach out to Harp
You can add the above to the missing logos issue I suggested above.
You can create an issue in the Parcel repo asking about a full logo. |
|
@nickytonline Sounds good, I'll start making those issues once this PR has been merged in |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Builds on #797
Includes the logos for most of the frameworks.
Some things to note:
Generally been opting for the icons themselves, but there's some with the full name of the framework in the logo if we'd rather use those:
Missing logos:
Other notes:
A picture of a cute animal (not mandatory, but encouraged)