Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

refactor: remove site #803

Merged
merged 2 commits into from
Aug 3, 2022
Merged

refactor: remove site #803

merged 2 commits into from
Aug 3, 2022

Conversation

ericapisani
Copy link
Contributor

Summary

Came out of a code review comment on #797

Wanted to have the removal of the site as a distinct set of changes outside of adding the Gatsby logo to the project.

Confirmed locally that the Netlify frontend continues to work as expected with these changes

A picture of a cute animal (not mandatory, but encouraged)

IMG_20220801_210001_014

Was limited in terms of what it was doing, and wasn't being used
@ericapisani ericapisani added the type: chore work needed to keep the product and development running smoothly label Aug 2, 2022
@ericapisani ericapisani self-assigned this Aug 2, 2022
sarahetter
sarahetter previously approved these changes Aug 2, 2022
nickytonline
nickytonline previously approved these changes Aug 2, 2022
Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this out! 🚀

works locally with only webpack-cli but is failing on netlify build
@kodiakhq kodiakhq bot merged commit cb494ea into main Aug 3, 2022
@kodiakhq kodiakhq bot deleted the ep/remove-site branch August 3, 2022 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants