This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: make esbuild work with ESM and require calls #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with 5a7562a largeDepsEsbuild: 2.2s⬇️ 2.03% decrease vs. 5a7562a LegendlargeDepsNft: 10.2s⬇️ 7.59% decrease vs. 5a7562a LegendlargeDepsZisi: 15.3s⬇️ 5.72% decrease vs. 5a7562a |
danez
force-pushed
the
esm-esbuild
branch
2 times, most recently
from
45fe0a8 to
c596234
Compare
| import { createRequire as ___nfyCreateRequire } from 'module'; | ||
| import { fileURLToPath as ___nfyFileURLToPath } from "url"; | ||
| import { dirname as ___nfyPathDirname } from "path"; | ||
| let __filename = ___nfyFileURLToPath(import.meta.url); |
There was a problem hiding this comment.
It just occurred to me that if the user code tries to declare these variables, we'll get an error. This only happens if the declaration happens in the same scope, though. Have you checked a sample bundle to see if this situation could happen?
There was a problem hiding this comment.
Esbuild is thankfully clever enough to rename variables
import renderNextPage from './renderNextPage'
const __dirname = 1
export const handler = async (event, context, callback) => {
...turns into
var import_renderNextPage = __toESM(require_renderNextPage(), 1);
var __dirname2 = 1;
var handler = async (event, context, callback) => {
...There was a problem hiding this comment.
But nevertheless i will put it behind FF
danez
added a commit
that referenced
this pull request
Nov 30, 2022
5 tasks
danez
added a commit
that referenced
this pull request
Nov 30, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a banner to esbuild if the output format is set to ESM. This banner makes require() calls work again.
This can happen when ezbuild produces ESM and some of the ESM modules import CJS modules which use
require.For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)