This repository has been archived by the owner on May 22, 2024. It is now read-only.
Check peerDependenciesMeta for Optional Dependencies #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotox
requested review from
ehmicky and
biilmann
and removed request for
ehmicky
|
Thanks a lot @devotox for this PR! |
|
@ehmicky when do you think this will be released and be used with Netlify CLI |
|
@devotox This should be live if you use the Netlify Build beta. |
|
@ehmicky I have not been given access to Netlify Build Beta and was wondering how I could use this with Netlify Actions. Would I need to fork it all? |
|
@DavidWells Would it be possible to give @devotox access to the Netlify Build beta? |
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…and-ship-it#83) Check peerDependenciesMeta for Optional Dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the optional dependencies check to also check peer dependencies meta
The Peer Dependencies Meta field was added to Yarn here:
Yarn#6671
This is used by a number of packages to allow them to be
yarn -pnpcompatible, most notably Knex.This feature was added in version 0.20.1
Unit tests are included but cannot be run as it cannot get to that branch of the code in a similar way as the
Ignore missing optional dependenciestest.Check Peer Dependencies Meta for Optional Dependencies