-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1743: handle file exits error using TCx hooks and update FC #363
NETOBSERV-1743: handle file exits error using TCx hooks and update FC #363
Conversation
@msherif1234: This pull request references NETOBSERV-1743 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=433e99a make set-agent-image |
Signed-off-by: Mohamed Mahmoud <[email protected]>
8512aab
to
b99a31d
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=585ab2b make set-agent-image |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage ? 32.70%
=======================================
Files ? 48
Lines ? 3605
Branches ? 0
=======================================
Hits ? 1179
Misses ? 2325
Partials ? 101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/lgtm |
/label qe-approved |
@msherif1234: This pull request references NETOBSERV-1743 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…netobserv#363) Signed-off-by: Mohamed Mahmoud <[email protected]>
…#363) Signed-off-by: Mohamed Mahmoud <[email protected]>
Description
when update FC the TCS handle is still attached to interface
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.