Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1739 move kernel version check to its own pkg #373

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 24, 2024

Description

move kernel version check to its own pkg

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau changed the title move kernel version check to its own pkg NETOBSERV-1739 move kernel version check to its own pkg Jul 24, 2024
@jpinsonneau
Copy link
Contributor

jpinsonneau commented Jul 24, 2024

Putting this as part of NETOBSERV-1739 with no-qe validation as it's trivial

@jpinsonneau jpinsonneau added the no-qe This PR doesn't necessitate QE approval label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0709e78). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage        ?   32.70%           
=======================================
  Files           ?       49           
  Lines           ?     3605           
  Branches        ?        0           
=======================================
  Hits            ?     1179           
  Misses          ?     2325           
  Partials        ?      101           
Flag Coverage Δ
unittests 32.70% <65.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/utils/utils.go 100.00% <ø> (ø)
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)
pkg/kernel/kernel_utils.go 66.66% <66.66%> (ø)

@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7acdf8d into netobserv:main Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants