-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1777: Allow DNS tracking to use configurable port for tracking #381
Conversation
@msherif1234: This pull request references NETOBSERV-1777 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage ? 30.04%
=======================================
Files ? 49
Lines ? 3937
Branches ? 0
=======================================
Hits ? 1183
Misses ? 2653
Partials ? 101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=c0a8217 make set-agent-image |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Today DNS tracking uses only port 53 which is the port defined for DNS service and it get mapped to different port at the container level to avoid root access. This change wil allow tracking at the pod level as well Signed-off-by: Mohamed Mahmoud <[email protected]>
8c251a2
to
45824dd
Compare
New changes are detected. LGTM label has been removed. |
just rebase |
/test all |
@msherif1234: This pull request references NETOBSERV-1777 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
Today DNS tracking uses only port 53 which is the
port defined for DNS service and it get mapped
to different port at the container level to
avoid root access. This change wil allow
tracking at the pod level as well
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.