Restore performances in filtering case #496
Conversation
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=7b27021 make set-agent-image |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 30.01% 29.98% -0.04%
==========================================
Files 48 48
Lines 4828 4833 +5
==========================================
Hits 1449 1449
- Misses 3269 3274 +5
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/lgtm |
pkg/tracer/tracer.go
Outdated
| if cfg.EnableFlowFilter { | ||
| enableFlowFiltering = 1 | ||
| for _, f := range cfg.FilterConfig { |
There was a problem hiding this comment.
nit: we can have this as function in flow_filter.go and call it or even move the flow_filter processing up and let it return the flag not urgent can be done later
There was a problem hiding this comment.
hmm yes ... while doing that I realize it's not handled in the bpfman case .. I need to duplicate that logic in the operator, for bpfman, right?
|
remember to delete the new const from the spec in |
@msherif1234 actually, shouldn't I add the same logic in the PacketFetcher code path ? |
packetfiltering has sampling on by default and it doesn't support sampling override |
github-actions
bot
removed
the
ok-to-test
|
@msherif1234 comments addressed |
|
/lgtm |
|
@jotak: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
...move sampling detection in flow_filter.go
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow-up on #488
Return early in case of filters being set without any conditional sampling.
As discussed here , some use cases would see a non negligible performance drop if we don't restore an optimal early return.