Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] NETOBSERV-2107 Disable worload metrics #176

Conversation

jpinsonneau
Copy link
Contributor

Backport of #174

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.53%. Comparing base (9fbccef) to head (55809cd).
Report is 1 commits behind head on release-1.8.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.8     #176   +/-   ##
============================================
  Coverage        23.53%   23.53%           
============================================
  Files               11       11           
  Lines             1330     1330           
============================================
  Hits               313      313           
  Misses            1000     1000           
  Partials            17       17           
Flag Coverage Δ
unittests 23.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jpinsonneau jpinsonneau requested review from jotak and memodi February 13, 2025 16:20
@memodi
Copy link

memodi commented Feb 13, 2025

/ok-to-test

Copy link

New image:
quay.io/netobserv/network-observability-cli:0a8fabf

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=0a8fabf make commands

or download the updated commands.

@jotak
Copy link
Member

jotak commented Feb 13, 2025

/lgtm

@memodi
Copy link

memodi commented Feb 13, 2025

we need to update the dashboard using these metrics? It shows empty empty panels currently:

image

@jpinsonneau
Copy link
Contributor Author

we need to update the dashboard using these metrics? It shows empty empty panels currently:

image

That's empty as every other panels not available yet. I'm planning to make all of this configurable for 1.9+

@jotak
Copy link
Member

jotak commented Feb 14, 2025

/lgtm

Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 08fcaf0 into netobserv:release-1.8 Feb 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants