Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1869 PoC on UDN UI #625

Closed
wants to merge 4 commits into from
Closed

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Oct 22, 2024

Description

This is a PoC around UDN improvements in netobserv UI using mock data.

You can run this UI locally using:

$ make start-standalone-mock

Implementations:

  • UDN graphs
  • extra column + filter on UDN name
  • topology grouping
  • clickable links bringing to UDN definition => need namespace + name here. For now, ids doesn't match
  • topology nodes / edges colors per UDN
  • additionnal 'Network traffic' tab for UDN kind

We need to decide how to store the UDN info. These can be namespaced so it will be good to have both Name + Namespace in two separate fields as we did for other K8S enrichments.
Or maybe we could reuse SrcK8S_Namespace ?

image
image
image
image
image

Dependencies

netobserv/netobserv-ebpf-agent#438
netobserv/flowlogs-pipeline#743

/!\ DO NOT MERGE THIS /!
I'll split that PR so we can merge feature by feature 😸

Copy link

openshift-ci bot commented Oct 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.98%. Comparing base (b7fdf62) to head (ca404b0).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
pkg/handler/resources.go 4.34% 21 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b7fdf62) and HEAD (ca404b0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b7fdf62) HEAD (ca404b0)
uitests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   55.96%   49.98%   -5.99%     
==========================================
  Files         193       37     -156     
  Lines        9491     3155    -6336     
  Branches     1215        0    -1215     
==========================================
- Hits         5312     1577    -3735     
+ Misses       3802     1413    -2389     
+ Partials      377      165     -212     
Flag Coverage Δ
uitests ?
unittests 49.98% <8.33%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/loki/topology_query.go 73.07% <ø> (+4.22%) ⬆️
pkg/model/fields/fields.go 88.88% <ø> (ø)
pkg/server/routes.go 71.15% <100.00%> (+0.42%) ⬆️
pkg/handler/resources.go 12.21% <4.34%> (-2.53%) ⬇️

... and 187 files with indirect coverage changes

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:4f7a60c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4f7a60c make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 7, 2024
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:a8ecf29

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a8ecf29 make set-plugin-image

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jpinsonneau
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold do-not-merge/work-in-progress needs-rebase ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants